cim/zitadel-oidc
5
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(op): initialize http Headers in response objects (#637)

Browse source 
* fix(op): initialize http Headers in response objects

* fix test

---------

Co-authored-by: Livio Spring <livio.a@gmail.com>
This commit is contained in:
Tim Möhlmann 2024-08-21 10:34:26 +03:00 • committed by GitHub
parent 99301930ed
commit 1e75773eaa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
pkg/op/error_test.go
View file

@ -428,6 +428,7 @@ func TestTryErrorRedirect(t *testing.T) {
parent: oidc.ErrInteractionRequired().WithDescription("sign in"), parent: oidc.ErrInteractionRequired().WithDescription("sign in"),
}, },
want: &Redirect{ want: &Redirect{
Header: make(http.Header),
URL: "http://example.com/callback?error=interaction_required&error_description=sign+in&state=state1", URL: "http://example.com/callback?error=interaction_required&error_description=sign+in&state=state1",
}, },
wantLog: `{ wantLog: `{

6
pkg/op/server.go
View file

@ -218,6 +218,7 @@ type Response struct {
// without custom headers. // without custom headers.
func NewResponse(data any) *Response { func NewResponse(data any) *Response {
return &Response{ return &Response{
Header: make(http.Header),
Data: data, Data: data,
} }
} }
@ -242,7 +243,10 @@ type Redirect struct {
} }
func NewRedirect(url string) *Redirect { func NewRedirect(url string) *Redirect {
return &Redirect{URL: url} return &Redirect{
Header: make(http.Header),
URL: url,
}
} }
func (red *Redirect) writeOut(w http.ResponseWriter, r *http.Request) { func (red *Redirect) writeOut(w http.ResponseWriter, r *http.Request) {