resolve (most) review comments

This commit is contained in:
Tim Möhlmann 2023-03-10 14:23:07 +02:00
parent 434b3fae82
commit 5bf72089b0
5 changed files with 57 additions and 19 deletions

View file

@ -154,6 +154,13 @@ func TestNewAccessTokenClaims(t *testing.T) {
want.Expiration.AsTime(), want.JWTID, "foo", time.Second,
)
// test if the dynamic timestamps are around now,
// allowing for a delta of 1, just in case we flip on
// either side of a second boundry.
nowMinusSkew := NowTime() - 1
assert.InDelta(t, int64(nowMinusSkew), int64(got.IssuedAt), 1)
assert.InDelta(t, int64(nowMinusSkew), int64(got.NotBefore), 1)
// Make equal not fail on dynamic timestamp
got.IssuedAt = 0
got.NotBefore = 0
@ -207,6 +214,12 @@ func TestNewIDTokenClaims(t *testing.T) {
time.Second,
)
// test if the dynamic timestamp is around now,
// allowing for a delta of 1, just in case we flip on
// either side of a second boundry.
nowMinusSkew := NowTime() - 1
assert.InDelta(t, int64(nowMinusSkew), int64(got.IssuedAt), 1)
// Make equal not fail on dynamic timestamp
got.IssuedAt = 0