cim/zitadel-oidc
5
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

review feedback -- additional potential races

Browse source
This commit is contained in:
David Sharnoff 2022-09-30 08:48:38 -07:00
parent 2067a740cc
commit 8e6a8fae1f
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pkg/client/rp/relying_party.go
View file

@ -154,7 +154,9 @@ func NewRelyingPartyOAuth(config *oauth2.Config, options ...Option) (RelyingPart
}
}
_ = rp.IDTokenVerifier()
// avoid races by calling these early
_ = rp.IDTokenVerifier() // sets idTokenVerifier
_ = rp.ErrorHandler() // sets errorHandler
return rp, nil
}

7
pkg/op/op.go
View file

@ -167,9 +167,10 @@ func NewOpenIDProvider(ctx context.Context, config *Config, storage Storage, opO
o.crypto = NewAESCrypto(config.CryptoKey)
// Avoid potential race conditions by calling these early
_ = o.AccessTokenVerifier()
_ = o.JWTProfileVerifier()
_ = o.openIDKeySet()
_ = o.AccessTokenVerifier() // sets accessTokenVerifier
_ = o.IDTokenHintVerifier() // sets idTokenHintVerifier
_ = o.JWTProfileVerifier() // sets jwtProfileVerifier
_ = o.openIDKeySet() // sets keySet
return o, nil
}