feat(op): always verify code challenge when available (#721)
Finally the RFC Best Current Practice for OAuth 2.0 Security has been approved. According to the RFC: > Authorization servers MUST support PKCE [RFC7636]. > > If a client sends a valid PKCE code_challenge parameter in the authorization request, the authorization server MUST enforce the correct usage of code_verifier at the token endpoint. Isn’t it time we strengthen PKCE support a bit more? This PR updates the logic so that PKCE is always verified, even when the Auth Method is not "none".
This commit is contained in:
parent
7096406e71
commit
c51628ea27
6 changed files with 45 additions and 15 deletions
|
@ -130,7 +130,7 @@ func TestServerRoutes(t *testing.T) {
|
|||
"client_id": client.GetID(),
|
||||
"client_secret": "secret",
|
||||
"redirect_uri": "https://example.com",
|
||||
"code": "123",
|
||||
"code": "abc",
|
||||
},
|
||||
wantCode: http.StatusBadRequest,
|
||||
json: `{"error":"invalid_grant", "error_description":"invalid code"}`,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue